Geniously efficient code in Microsoft.Expression.Interactions.dll

Geniously efficient code in Microsoft.Expression.Interactions.dll by Andrii.C.Sharp

Active

Type:	Bug
ID:	773859
Opened:	12/8/2012 1:03:55 PM
Access Restriction:	Public

Workaround(s)

view

User(s) can reproduce this bug

Look at this (line 2, it is from TypeConverterHelper class):
StringBuilder builder = new StringBuilder();
builder.Append("<ContentControl xmlns='http://schemas.microsoft.com/client/2007' xmlns:c='" + ("clr-namespace:" + nullableType.Namespace + ";assembly=" + nullableType.Assembly.FullName.Split(new char[] { ',' })[0]) + "'>\n");
builder.Append("<c:" + nullableType.Name + ">\n");
builder.Append(a);
builder.Append("</c:" + nullableType.Name + ">\n");
builder.Append("</ContentControl>");

It is similar to
bool a;
...
if (a.ToStrng().Length == 4)

Maybe this way it will work better:
builder.AppendFormat("<ContentControl xmlns='http://schemas.microsoft.com/client/2007' xmlns:c='{0}'>\n", string.Concat("clr-namespace:", nullableType.Namespace, ";assembly=", nullableType.GetTypeInfo().Assembly.FullName.Split(new char[] { ',' })[0]));
builder.AppendFormat("<c:{0}>\n", nullableType.Name);
builder.Append(a);
builder.AppendFormat("</c:{0}>\n", nullableType.Name);
builder.Append("</ContentControl>");

Details (expand)

Blend

Blend 4 SP1 (4.0.20901.0)

Suggestion

0 attachments

Look also at this:

private void ValidateStateName(string stateName)
{
    if ((base.AssociatedObject != null) && !string.IsNullOrEmpty(stateName))
    {
        foreach (VisualState state in this.TargetedVisualStates) // <<<<<<<<<<<<<<<<<< HERE! It can be written in 1 line without additional method!!! Example is below
        {
            if (stateName == state.Name)
            {
                return;
            }
        }
        throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, ExceptionStringTable.DataStateBehaviorStateNameNotFoundExceptionMessage, new object[] { stateName, (this.TargetObject != null) ? this.TargetObject.GetType().Name : "null" }));
    }
}

private IEnumerable<VisualState> TargetedVisualStates
{
    get
    {
        List<VisualState> list = new List<VisualState>();
        if (this.TargetObject != null)
        {
            foreach (VisualStateGroup group in VisualStateUtilities.GetVisualStateGroups(this.TargetObject))
            {
                foreach (VisualState state in group.States)
                {
                    list.Add(state);
                }
            }
        }
        return list;
    }
}

And look at this:

        private void ValidateStateName(string stateName)
        {
            if ((base.AssociatedObject != null) && !string.IsNullOrEmpty(stateName))
            {
                if (!VisualStateUtilities.GetVisualStateGroups(this.TargetObject)
                        .Any(visualStateGroup => visualStateGroup.States
                            .Any(visualState => visualState.Name == stateName)))
                {
                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, ExceptionStringTableHelper.DataStateBehaviorStateNameNotFoundExceptionMessage, new object[] { stateName, (this.TargetObject != null) ? this.TargetObject.GetType().Name : "null" }));
                }
            }
        }

Which option is better?