CMFCRibbonButton constructor with HICON by Guglielmo Calligaro

Use this

class CMFCRibbonButton2 : public CMFCRibbonButton
{
protected:
    bool m_bSmallMode;

public:
    CMFCRibbonButton2(void) : m_bSmallMode(false)
    {}
    CMFCRibbonButton2(UINT nID, LPCTSTR lpszText, int nSmallImageIndex=-1, int nLargeImageIndex=-1, BOOL bAlwaysShowDescription=FALSE)
        : m_bSmallMode(false), CMFCRibbonButton(nID, lpszText, nSmallImageIndex, nLargeImageIndex, bAlwaysShowDescription)
    {}
    CMFCRibbonButton2(UINT nID, LPCTSTR lpszText, HICON hIcon, BOOL bAlwaysShowDescription=FALSE, HICON hIconSmall=NULL, BOOL bAutoDestroyIcon=FALSE, BOOL bAlphaBlendIcon=FALSE)
        : m_bSmallMode(false), CMFCRibbonButton(nID, lpszText, hIcon, bAlwaysShowDescription, hIconSmall, bAutoDestroyIcon, bAlphaBlendIcon)
    {}

public:
    void SetSmallMode(void)
    { m_bSmallMode = true; }
    void SetLargeMode(void)
    { m_bSmallMode = false; }

public:
    virtual BOOL HasLargeMode() const
    {
        if (m_bSmallMode)
            return FALSE;
        return __super::HasLargeMode();
    }
};


// Create button and call this
pBtn2->SetSmallMode();

Hello,

Thanks for the report. We have investigated and found that this is a design bug: initially, it was assumed that each icon-based ribbon button MUST have a large icon. However, the possible fix may cause a backward-compatibility problems so we are not going to fix this, at least for Visual Studio 2010.

However, I can propose the following simple workaround - it does work:

class CSmallIconButton : public CMFCRibbonButton
{
public:
CSmallIconButton (UINT nID, LPCTSTR lpszText, HICON hIcon) :
CMFCRibbonButton(nID, lpszText, NULL, FALSE, hIcon)
{
}

virtual CSize GetImageSize (RibbonImageType type) const
{
if (type == RibbonImageLarge || m_hIconSmall == NULL)
{
return CSize(0, 0);
}

CSize sizeIcon(16, 16);

if (afxGlobalData.GetRibbonImageScale () != 1.)
{
sizeIcon.cx = (int) (.5 + afxGlobalData.GetRibbonImageScale () * sizeIcon.cx);
sizeIcon.cy = (int) (.5 + afxGlobalData.GetRibbonImageScale () * sizeIcon.cy);
}

return sizeIcon;
}

virtual void DrawImage (CDC* pDC, RibbonImageType type, CRect rectImage)
{
ASSERT_VALID (this);
ASSERT_VALID (pDC);

if (type != RibbonImageSmall || m_hIconSmall == NULL)
{
return;
}

CSize sizeIcon = GetImageSize(type);
::DrawIconEx (pDC->GetSafeHdc (), rectImage.left, rectImage.top, m_hIconSmall, sizeIcon.cx, sizeIcon.cy, 0, NULL, DI_NORMAL);
}
};

Use this class instead of CMFCRibbonButton:

//Create buttons
CIconButton* pButtonA = new CSmallIconButton(ID_APP_ABOUT, L"A", hIconA);
CIconButton* pButtonB = new CSmallIconButton(ID_APP_ABOUT, L"B", hIconB);
CIconButton* pButtonC = new CSmallIconButton(ID_APP_ABOUT, L"B", hIconC);

Please give this a try. Hope this helps to solve the issue.

Pat Brenner
Visual C++ Libraries Development

With the code you suggested the icon disappear so this will not fix the problem.
I've tried this before to post this as a bug.
I've seen MFC code and It cannot work without a correction.

Hello,

Thanks for the report. We have investigated and found that this is by design, because you are passing a small icons to the CMFCButton constructor as the large icon parameter.

If you replace this code:

//Create buttons
CMFCRibbonButton* pButtonA = new CMFCRibbonButton(ID_TESTA, L"A", hIconA);
CMFCRibbonButton* pButtonB = new CMFCRibbonButton(ID_TESTB, L"B", hIconB);
CMFCRibbonButton* pButtonC = new CMFCRibbonButton(ID_TESTC, L"C", hIconC);

with this code instead:

//Create buttons
CMFCRibbonButton* pButtonA = new CMFCRibbonButton(ID_TESTA, L"A", NULL, FALSE, hIconA);
CMFCRibbonButton* pButtonB = new CMFCRibbonButton(ID_TESTB, L"B", NULL, FALSE, hIconB);
CMFCRibbonButton* pButtonC = new CMFCRibbonButton(ID_TESTC, L"C", NULL, FALSE, hIconC);

then the icons will be treated as 16x16 images and the buttons will line up as you expect.

Pat Brenner
Visual C++ Libraries Development

Thank you for your feedback, We are currently reviewing the issue you have submitted. If this issue is urgent, please contact support directly(http://support.microsoft.com)