Incomplete documentation for CMFCColorButton class

Incomplete documentation for CMFCColorButton class by DD Blue Ox

Closed

as Fixed

Type:	Suggestion
ID:	600357
Opened:	9/17/2010 8:44:23 AM
Access Restriction:	Public

Workaround(s)

view

What the documentation for CMFCColorButton neglects to mention is that if you follow the directions in the documentation, the "other" button won't work except for system colors (and then the second parameter of the EnableOtherButton method must be FALSE). To give the "other" button its full functionality you need to add the following to your .rc2 resource file:

#ifndef _AFXDLL
#include "afxribbon.rc" // Ribbon and control bars.
#endif

Leave at least one blank line after this code so the compiler doesn't complain. You can't add this include statement to the .rc file because Visual Studio would overwrite it the next time you make a change to any resource. Visual Studio doesn't edit the .rc2 file so it's safe there.

This addition is necessary even if you add a CMFCColorButton in the VS2010 designer. The designer SHOULD add the code to the .rc file but it doesn't do so. This appears to be a bug in the way that control has been configured in the designer.

Dennis Dykstra

Details (expand)

Visual Studio 2010

Reliability

1. Create an MFC dialog application.
2. In the VS2010 designer, add a CMFCColorButton.
3. In the dialog's OnInitDialog method, initialize the color button. For instance, if the color button's ID is IDC_CBTN:

((CMFCColorButton*)GetDlgItem(IDC_CBTN))->EnableOtherButton(L"More colors...");

This initializes the "other" button with second and third parameters set to their default values of TRUE, thus indicating that the button should pull up the CMFCColorBar control and that the button should be enabled.

Unless the code indicated above is added to the .rc2 file, clicking the "other" button will have no effect.

English

Windows Vista

English

Clicking the "other" button has no effect.

Clicking the "other" button should instantiate and display the CMFCColorBar control.

0 attachments

Hello Dennis,

Thanks for the report. This issue has already been fixed in the MFC application wizard for the next major release of Visual Studio.

Your workaround is one way to fix the issue. The other is to add the #include of afxribbon.rc to the project RC file (right near the same location where afxres.rc is included). This is the fix I made to the wizard-generated code. Note that the additional resources are only necessary when MFC is used from a static library--then you need the resources in your executable. If MFC is used from a DLL, then the resources are found in the DLL and do not need to be included in your EXE.

Pat Brenner
Visual C++ Libraries Development