Search

New file "afxanimationcontroller.h" uses TRACE instead of ATLTRACE by Hendrik Wagenaar

Closed
as Fixed Help for as Fixed

1
0
Sign in
 to vote
Type: Bug
ID: 635819
Opened: 1/12/2011 6:07:54 PM
Access Restriction: Public
0
Workaround(s)
0
User(s) can reproduce this bug
the new file ..\microsoft visual studio 10.0\vc\atlmfc\include\afxanimationcontroller.h uses TRACE() inside of ATLTRACE().

While technically not wrong, it causes issues with our build. We have our own TRACE defined which uses wide chars, so we get errors while compiling with SP1 beta.
Details (expand)

Visual Studio/Silverlight/Tooling version

Visual Studio 2010 SP1 Beta

What category (if any) best represents this feedback?

Compatibility

Steps to reproduce

Define a TRACE() macro which calls a wide char function, and try compiling something that somehow includes afxanimationcontroller.h

Product Language

English

Operating System

Windows 7

Operating System Language

English

Actual results

Unable to compile

Expected results

It would be nice if the new file followed the existing convention of using ATLTRACE
File Attachments
0 attachments
Sign in to post a comment.
Posted by Microsoft on 1/14/2011 at 1:12 PM
Hello Hendrik,

This issue will be fixed in MFC for the next major release of Visual Studio. Thanks again for the report.

Pat Brenner
Visual C++ Libraries Development
Posted by Microsoft on 1/14/2011 at 9:51 AM
Hello Hendrik,

Thanks for the clarification. I now understand the issue. Unfortunately, we are unable to apply the fix for Visual Studio 2010 SP1 RTM but the issue will be fixed in the next major release of Visual Studio.

I think it should be fairly easy to find a workaround but let me know if you need assistance with this.

Pat Brenner
Visual C++ Libraries Development
Posted by Hendrik Wagenaar on 1/14/2011 at 6:13 AM
>> why wasn't it posted here
oops -- I guess I hadn't refreshed the window.
Posted by Hendrik Wagenaar on 1/14/2011 at 6:10 AM
In reply to the following email (why wasn't it posted here?):

"Hello Hendrik, Thanks for the report. We consider this to be by design. MFC uses the TRACE macro in AFX.H and all the MFC sources, so there is no existing convention of using ATLTRACE in MFC
(though TRACE is #defined to ATLTRACE in AFX.H). Pat Brenner"

The real issue is that the strings passed to TRACE in afxanimationcontroller.h are not wrapped in _T("")

Please update the header, Thanks

Posted by Microsoft on 1/13/2011 at 1:31 PM
Hello Hendrik,

Thanks for the report. We consider this to be by design. MFC uses the TRACE macro in AFX.H and all the MFC sources, so there is no existing convention of using ATLTRACE in MFC (though TRACE is #defined to ATLTRACE in AFX.H).

Pat Brenner
Visual C++ Libraries Development
Posted by Microsoft on 1/13/2011 at 1:08 AM
Thanks for your feedback.

We are rerouting this issue to the appropriate group within the Visual Studio Product Team for triage and resolution. These specialized experts will follow-up with your issue.
Sign in to post a workaround.
© 2013 Microsoft Corporation. All rights reserved. Microsoft Connect Terms of Use | Trademarks | Privacy Statement