CMFCToolBarImages may cause ActiveX host shutdown failure by Greg Prosch

Hi Greg,

Thanks for the responses. I am glad to hear that the fix in SP1 has resolved the problem for you. Do you happen to have a small repro case that we can use to verify for ourselves? This would also help us to make sure that we don't cause regressions in this area. Thanks!

Pat Brenner
Visual C++ Libraries Development

I see now that my further problem resulted from not calling CWinApp::ExitInstance before calling the GDI+ shutdown logic. All is well now that I am using SP1 beta and making that call first.

It appears that your assertion is correct in that the CMFCToolBarImages::CleanUp function is being called during CWinApp destruction in SP1. Unfortunately, my implementation is inside an ActiveX control where I am managing GDI+ resources. This necessitates that I call the NotificationHook/Unhook methods. If I don't invoke CMFCToolBarImages::CleanUp prior to calling NotificationUnhook then a GDI+ thread will be spawned which will cause my app to hang on shutdown.

I have successfully worked around this issue though by making calls in the following order from my ExitInstance:

        // Explicitly free static DC's
    CMFCToolBarImages::CleanUp();    

    // Ensure that the VisualManager resources are properly released.
    CMFCVisualManager::DestroyInstance();

    if (NULL != m_gdiplusToken)
    {
        if (NULL != m_gdiplusHookToken)
        {
            m_gdiplusStartupOutput.NotificationUnhook(m_gdiplusHookToken);
        }

        // Release GDI+ resources.
        GdiplusShutdown(m_gdiplusToken);
    }

Hello,

Thanks for the report. I believe this issue has been fixed in VS2010 SP1. The call to ControlBarCleanup (which in turn calls CMFCToolBar::CleanUpImages, which in turn calls CMFCToolBarImages::CleanUp) has been moved from CWinAppEx::ExitInstance to CWinApp::ExitInstance, so all CWinApp-derived classes will clean up the images on exit.

This should fix the issue that you are reporting, since it causes the same code path to be executed as your workaround does. We are attempting to verify here, but if you have an example with which we can reproduce the problem we can make sure.

Pat Brenner
Visual C++ Libraries Development

Thank you for reporting this issue.
Could you please attach a project to help us reproduce this issue?

Thank you for your feedback, we are currently reviewing the issue you have submitted. If this issue is urgent, please contact support directly(http://support.microsoft.com)