Denali CTP3 Upgrade Advisor misses deprecated RAISERROR syntax - by TomPullen

Status : 

  Won't Fix<br /><br />
		Due to several factors the product team decided to focus its efforts on other items.<br /><br />
		A more detailed explanation for the resolution of this particular item may have been provided in the comments section.


5
0
Sign in
to vote
ID 694484 Comments
Status Closed Workarounds
Type Bug Repros 3
Opened 10/12/2011 5:30:18 AM
Access Restriction Public

Description

I downloaded the CTP3 Upgrade Advisor from this site

http://www.microsoft.com/download/en/details.aspx?id=26726

and ran it against a Production 2008R2 instance that I know has Procs in it that contain obsolete RAISERROR syntax (where you use it without any brackets/parentheses).

This syntax does not compile in Denali CTP 3 Refresh + QFE so I believe that the UA should pick this up.
Sign in to post a comment.
Posted by Piquet on 4/22/2013 at 4:11 PM
I discovered this exact same problem, post-upgrade to SQL 2012...

I'm surprised that there are so many reported uses of this "undocumented?" feature/usage of RAISERROR - in my case the code / s-proc with an issue was from the SQL 2000 era, so perhaps it WAS a documented feature / usage back then?

I'm even more surprised at Umachandar's comments. The syntax for the no longer supported usage of RAISERROR would be quite easily detected, and given the fact that this usage or RAISERROR was supported in SQL2008R2 but is no longer supported by SQL2012, it is a classic candidate for inclusion as a SQL Upgrade Advisor code-check rule.

I cannot believe that such a simple check would not be easily supported by Upgrade Advisor's existing parser - the SQL Server T-SQL parser as well as the intellisense built into SSMS has no problem detecting this invalid usage...

I strongly agree with Nizamettin on this issue - Microsoft should0RE-OPEN THIS ISSUE and include a checking rule for this type of RAISERROR usage in the SQL2012 Upgrade Advisor.
Posted by Nizamettin Özpolat on 2/9/2013 at 2:25 PM
I was surprised when I hit this issue. I ran upgrade advisor against my databases. There was no issue except one clr issue which was not much problem. But when I checked all discontinued issues one by one, I realised that there are lots of issues about raiserror discontinued feature.
I'm shocked now that microsoft knows this issue for a long time and did not produce a solution even though SP1 allready released.
Please, open this issue and produce a solution.
Posted by sppdba on 2/8/2013 at 8:55 AM
Is this still a case of 'won't fix' with SQL 2012 SP1?
Posted by Umachandar [MSFT] on 10/12/2011 at 4:09 PM
Hello Tom,
Thanks for reporting this issue. Unfortunately, the deprecated syntax for RAISERROR cannot be easily detected using the existing parser in Upgrade Advisor. Moreover the RAISERROR syntax that has been deprecated in Denali was undocumented. So I am closing this issue as "won't fix".

--
Umachandar, SQL Programmability Team