Gated Check in does not accept check on partial success (test failures only) - by Shunsoku

Status : 

  By Design<br /><br />
		The product team believes this item works according to its intended design.<br /><br />
		A more detailed explanation for the resolution of this particular item may have been provided in the comments section.


2
0
Sign in
to vote
ID 521013 Comments
Status Closed Workarounds
Type Bug Repros 2
Opened 12/17/2009 12:28:41 PM
Access Restriction Public

Description

I had a gated check in definition that had the fail build on test failure set to False and yet when it ran the tests (which failed) it rejected my check in. This appears to be a bug. I assumed that it would accept the check in even though the tests failed.
Sign in to post a comment.
Posted by Joel Corra on 8/31/2011 at 11:48 AM
This seems to directly contradict the setting "Fail build on test failure". What's the point of even having that setting if your build is rejected by a gated check-in regardless? Or give the option on the gated check-in to allow only "fully" successful or allow partially successful builds. Either way would make more sense. As it is, it's very misleading, and assumed to be a bug in TFS. I think the end result is that it's more likely to cause development teams new to writing unit tests to just abandon it altogether rather than deal with settings in TFS that don't seem to actually do what they say they do.
Posted by Microsoft on 12/22/2009 at 5:53 AM
This is by design - the CheckInGatedChanges activity, by default, only checks in the changes if both CompilationStatus and TestStatus are Succeeded. If you want to override this behavior, it is fairly straightforward - you can use the IgnoreErrors property of the CheckInGatedChanges activity to have it check in regardless of the values of CompilationStatus and TestStatus and then put whatever conditional logic you wish directly into the workflow. If you are using the default template, you'll just need to modify DefaultTemplate.xaml for each affected team project (if you will be creating lots of new ones, you can modify the template in the Team Project Process Template directly, after which all new team projects will pick up the changes). Similarly, if you are using the upgrade template, you'll need to modify UpgradeTemplate.xaml.
Posted by Microsoft on 12/20/2009 at 10:47 PM
Thanks for your feedback.

We are rerouting this issue to the appropriate group within the Visual Studio Product Team for triage and resolution. These specialized experts will follow-up with your issue.

Thank you
Posted by Microsoft on 12/18/2009 at 2:53 AM
Thank you for your feedback, we are currently reviewing the issue you have submitted. If this issue is urgent, please contact support directly(http://support.microsoft.com)